RFR: 8252062: WebKit build fails with recent VS 2019 compiler

Kevin Rushforth kcr at openjdk.java.net
Wed Sep 2 15:48:28 UTC 2020

On Wed, 2 Sep 2020 15:33:23 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> The WebKit build fails with recent VS 2019 compiler.
>> Bug: This MediaQueryEvaluator constructor takes a String parameter, but the conversion of char* to String is failing.
>> Fix: Use the default constructor of MediaQueryEvaluator, which also returns true for "all".
>> Test: Build webkit with the recent VS 2019 compiler with and without this fix. It should fail without the fix and build
>> with the fix.
> Marked as reviewed by kcr (Lead).

This is simple enough that a single reviewer will suffice.


PR: https://git.openjdk.java.net/jfx/pull/294

More information about the openjfx-dev mailing list