RFR: 8252936: Optimize removal of listeners from ExpressionHelper.Generic

dannygonzalez github.com+6702882+dannygonzalez at openjdk.java.net
Wed Sep 9 06:55:45 UTC 2020

On Tue, 8 Sep 2020 20:14:48 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>>> So I'd like to propose this third alternative, which would affect only VirtualFlow and the controls that use it, but
>>> wouldn't have any impact in the rest of controls as the other two options (as ExpressionHelper or Node listeners
>>> wouldn't be modified).
>> Given PR #185, which was mentioned above, (it isn't out for review yet, but I want to evaluate it), this would be a 4th
>> approach.
>> As long as this really doesn't introduce a leak, it seems promising.
>> I note that these are not mutually exclusive.
>> We should discuss this on the list and not just in one or more of of the 3 (soon to be 4) open pull requests.
> @dannygonzalez Per [this message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-September/027534.html) on
> the openjfx-dev mailing list, I have filed a new JBS issue for this PR to use. Please change the title to:
> 8252936: Optimize removal of listeners from ExpressionHelper.Generic

Thanks @kevinrushforth, I've changed the title.


PR: https://git.openjdk.java.net/jfx/pull/108

More information about the openjfx-dev mailing list