RFR: 8218973: SVG with masking is not rendering image with mask effect [v7]

Kevin Rushforth kcr at openjdk.java.net
Fri Sep 11 00:32:13 UTC 2020

On Fri, 7 Aug 2020 14:54:14 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision:
>>   Removed RenderSVGResourceMasker changes and added fix for HIDPI mask rendering
> modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp line 235:
>> 233:     } else {
>> 234:         if (m_state.fillGradient) {
>> 235:             setCTM(m_state.transform);
> Why is this needed here, but not in the other places `setGradient` is called? Won't there be a similar problem with
> `strokeRect`, `fillPath`, etc?

This question is still outstanding. It seems like the call to `setCTM` is either needed before all of the `setGradient`
calls or none of them. Can you comment?


PR: https://git.openjdk.java.net/jfx/pull/213

More information about the openjfx-dev mailing list