RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v11]

Ambarish Rapte arapte at openjdk.java.net
Fri Sep 11 10:20:39 UTC 2020

On Wed, 9 Sep 2020 12:15:51 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>>   rename tests
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java line 1514:
>> 1512:         return ((KeyMapping)mappings.get(i)).getInterceptor().test(null);
>> 1513:     }
>> 1514:
> his throws an NPE without the fix - which makes the test using this method still fail (good!), but a bit unspecific for
> my taste. A slight re-organisation of the helpers might help: move the asserts down instead of returning a boolean.

Change function as you suggested. Unlike ListViewTest, ComboBoxTest needs to verify if the interceptor correctly
evaluates to either true or false, so it needed a minor tweak to use `assertEquals()`


PR: https://git.openjdk.java.net/jfx/pull/172

More information about the openjfx-dev mailing list