RFR: 8246745: ListCell/Skin: misbehavior on switching skin [v2]

Kevin Rushforth kcr at openjdk.java.net
Fri Sep 11 12:01:08 UTC 2020

On Fri, 11 Sep 2020 09:57:09 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> ListCellSkin installs listeners to the ListView/fixedCellSize that introduce a memory leak, NPE on replacing the
>> listView and incorrect update of internal state (see bug report for details)
>> Fixed by removing the listeners (and the internal state had been copied from listView on change) and access of listView
>> state when needed.
>> Added tests that failed before and pass after the fix, plus a sanity test to guarantee same (correct) behavior
>> before/after.
> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>   added code comment as requested in review

Marked as reviewed by kcr (Lead).


PR: https://git.openjdk.java.net/jfx/pull/251

More information about the openjfx-dev mailing list