RFR: 8252547: Correct transformations docs in Node [v4]

Kevin Rushforth kcr at openjdk.java.net
Sat Sep 12 14:49:45 UTC 2020

On Sat, 12 Sep 2020 13:53:49 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Correction to the order of transforms specified in the docs of `Node`.
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>   Replaced link

Changes look good to me. I asked one question about whether you wanted to add another hyperlink, but it's up to you.

modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 336:

> 334:  * The transforms are applied in the reverse order of the matrix multiplication outlined above: last element of
> the transforms list 335:  * to 0th element, scale, rotate, and layout and translate. By applying the transforms in this
> order, the bounds in the local 336:  * coordinates of the node are transformed to the bounds in the parent coordinate
> of the node (see the <b>Bounding Rectangles</b>

Maybe hyperlink to the Bounding Rectangles section? (although as it is right below, it isn't as important).


Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/293

More information about the openjfx-dev mailing list