RFR: 8253086: Optimization of removeAll and retainAll of ObservableListWrapper

Nir Lisker nlisker at openjdk.java.net
Wed Sep 16 08:57:51 UTC 2020

On Mon, 14 Sep 2020 09:57:26 GMT, yosbits <github.com+7517141+yososs at openjdk.org> wrote:

> https://bugs.openjdk.java.net/browse/JDK-8253086
> ObservableListWrapper.java
>  * public boolean removeAll(Collection<?> c)
> * public boolean retainAll(Collection<?> c)
> These two methods use BitSet, but it doesn't make sense.
> By rewriting to the equivalent behavior that does not use BitSet, it is possible to reduce the CPU load in a wide range
> of use cases.
> The test is done with the following command.
> * gradle base: test
> * gradle controls: test

I will review this.
@kevinrushforth I am not able to self-request a review. Is it on purpose?


PR: https://git.openjdk.java.net/jfx/pull/305

More information about the openjfx-dev mailing list