RFR: 8253086: Optimization of removeAll and retainAll of ObservableListWrapper

Kevin Rushforth kcr at openjdk.java.net
Wed Sep 16 12:04:08 UTC 2020

On Wed, 16 Sep 2020 08:41:58 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8253086
>> ObservableListWrapper.java
>>  * public boolean removeAll(Collection<?> c)
>> * public boolean retainAll(Collection<?> c)
>> These two methods use BitSet, but it doesn't make sense.
>> By rewriting to the equivalent behavior that does not use BitSet, it is possible to reduce the CPU load in a wide range
>> of use cases.
>> The test is done with the following command.
>> * gradle base: test
>> * gradle controls: test
> I will review this.
> @kevinrushforth I am not able to self-request a review. Is it on purpose?

I think it's some sort of GitHub permission issue. I was hoping that once people were added to the OpenJDK org anyone
in that org could self-request a review (or even request a review of someone else in the org), but that doesn't seem to
be the case. :(


PR: https://git.openjdk.java.net/jfx/pull/305

More information about the openjfx-dev mailing list