RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v2]
kcr at openjdk.java.net
Wed Sep 16 12:56:39 UTC 2020
On Wed, 16 Sep 2020 11:03:55 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> Regarding your additional comments:
>>> * "Use Unix-style (LF) line endings not DOS-style (CRLF)" needs a comma before "not".
>>> * "Line width is no more than 120 characters" I remember that it was 130 or 135 somewhere.
>> You're probably remembering an old version, but it's been 120 for a while now.
>>> * "Wildcard imports (import foo.bar.baz.*) are forbidden" Junit imports use them extensively.
>> Fixed to add an exception for wildcard static imports in tests.
>>> * `./gradlew all test` will cause failure on webkit tests if it was not built.
>> Added a note about this and a pointer to the [Web Testing](WEBKIT-MEDIA-STUBS.md) doc.
> The "New features / API additions" repeats some things already stated. Is it to make each section independent?
I wanted the "New features / API additions" section to stand on its own. Once thing that might be redundant now is the
following sentence in the "Contributing code and documentation changes" section:
"Feature requests, in particular, must be discussed ahead of time and will require significant effort on your part."
I think that could be removed or incorporated in "New features / API additions".
More information about the openjfx-dev