RFR: 8253086: Optimization of removeAll and retainAll of ObservableListWrapper [v4]

yosbits github.com+7517141+yososs at openjdk.java.net
Tue Sep 22 07:35:49 UTC 2020

> https://bugs.openjdk.java.net/browse/JDK-8253086
> ObservableListWrapper.java
>  * public boolean removeAll(Collection<?> c)
> * public boolean retainAll(Collection<?> c)
> These two methods use BitSet, but it doesn't make sense.
> By rewriting to the equivalent behavior that does not use BitSet, it is possible to reduce the CPU load in a wide range
> of use cases.
> The test is done with the following command.
> * gradle base: test
> * gradle controls: test

yosbits has refreshed the contents of this pull request, and previous commits have been removed. The incremental views
will show differences compared to the previous content of the PR. The pull request contains one new commit since the
last revision:

  8253086: Optimization of removeAll and retainAll of ObservableListWrapper


  - all: https://git.openjdk.java.net/jfx/pull/305/files
  - new: https://git.openjdk.java.net/jfx/pull/305/files/4c61c071..8b319c6d

 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=305&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=305&range=02-03

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/305.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/305/head:pull/305

PR: https://git.openjdk.java.net/jfx/pull/305

More information about the openjfx-dev mailing list