RFR: 8244297: memory leak test utility [v4]

Ambarish Rapte arapte at openjdk.java.net
Fri Sep 25 07:10:13 UTC 2020

On Thu, 7 May 2020 16:08:25 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> It's based on the discussion of my previous PR: https://github.com/openjdk/jfx/pull/71
>> I Added test utility class copied from JMemoryBuddy and used it to simplify 4 of the existing unit tests.
>> It's a direct copy of my project [JMemoryBuddy](https://github.com/Sandec/JMemoryBuddy) without any changes.
>> I'm also using it in most of the projects I'm involved with and in my experience, the tests with this Library are very
>> stable. I can't remember wrong test results. Sometimes the memory behaviour of some libraries itself is not stable but
>> the tests with JMemoryBuddy are basically always correct.
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>   JDK-8244297
>   Improved the JavaDoc for JMemoryBuddy

Tests fail to compile, please correct the import.
Pointed error in `ToggleButtonTest`, please check other files also when correcting this.

modules/javafx.controls/src/test/java/test/javafx/scene/control/ToggleButtonTest.java line 45:

> 43: import org.junit.Before;
> 44: import org.junit.Test;
> 45: import de.sandec.jmemorybuddy.JMemoryBuddy;

Throws compilation error:  package de.sandec.jmemorybuddy does not exist

modules/javafx.controls/src/test/java/test/javafx/scene/control/ToggleButtonTest.java line 161:

> 159:
> 160:     @Test public void toggleGroupViaGroupAddAndRemoveClearsReference() {
> 161:         JMemoryBuddy.memoryTest(checker -> {

Compilation error: cannot find symbol JMemoryBuddy


Changes requested by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/204

More information about the openjfx-dev mailing list