RFR: 8251946: ObservableList.setAll does not conform to specification [v3]

Leon Linhart github.com+4029915+TheMrMilchmann at openjdk.java.net
Fri Sep 25 16:47:37 UTC 2020

On Fri, 25 Sep 2020 15:49:12 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Makes sense to me. I changed it accordingly.
> I don't think this change is correct.  `setAll(Collection)` should return true if the list is modified. As discussed in
> an [earlier comment](#issuecomment-684117392) this means returning true if either the existing Collection or the new
> Collection is non-empty.

I'm sorry, you're absolutely right. I didn't spend enough time thinking about the change and assumed it was fine since
the tests passed. Turns out the test didn't cover it. I reverted that part of the change and improved the test.


PR: https://git.openjdk.java.net/jfx/pull/284

More information about the openjfx-dev mailing list