RFR: 8251946: ObservableList.setAll does not conform to specification [v4]

Leon Linhart github.com+4029915+TheMrMilchmann at openjdk.java.net
Sat Sep 26 16:04:16 UTC 2020

> Hi, this PR fixes [JDK-8251946](https://bugs.openjdk.java.net/browse/JDK-8251946) computing whether the list was
> actually modified instead of just returning `true`. The list was modified if 1. it was not empty (modified by calling
> `#clear()`), or if 2. it was modified as result of the `#addAll()` call.
> If you want any test coverage for this please let me know.
> I reported the issue a couple of days ago via web formula and waited for the confirmation to open this PR but now I see
> that @kevinrushforth (sorry for pinging) is already assigned to the JBS issue. I'm not too familiar with how you handle
> JBS issues or more specifically whether assigning is used to indicate that the issue is in the assignee's "domain", or
> that the assignee is already working on it. In the latter case, please feel free to close this PR. (My OCA submission
> is still pending anyway.)

Leon Linhart has updated the pull request incrementally with one additional commit since the last revision:

  Test return value of setAll on an empty list


  - all: https://git.openjdk.java.net/jfx/pull/284/files
  - new: https://git.openjdk.java.net/jfx/pull/284/files/5f260d7e..5de1a51f

 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=284&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=284&range=02-03

  Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/284.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/284/head:pull/284

PR: https://git.openjdk.java.net/jfx/pull/284

More information about the openjfx-dev mailing list