Integrated: 8242621: TabPane: Memory leak when switching skin

Ambarish Rapte arapte at
Thu Jan 7 03:21:58 UTC 2021

On Tue, 13 Oct 2020 12:56:10 GMT, Ambarish Rapte <arapte at> wrote:

> `TabPaneSkin` installs some listeners that are not removed when `TabPaneSkin` is changed.
> The fix converts listeners to WeakListeners and also removes them on dispose.
> There is a NPE check change needed in `isHosrizontal()`. Without this check it causes NPE if pulse is in progress while TabPaneSkin is getting disposed.
> `SkinMemoryLeakTest` already had a test which only needed to be enabled. 
> Test fails before and passes after this change.

This pull request has now been integrated.

Changeset: c197b624
Author:    Ambarish Rapte <arapte at>
Stats:     131 lines in 4 files changed: 106 ins; 15 del; 10 mod

8242621: TabPane: Memory leak when switching skin

Reviewed-by: fastegal, kcr



More information about the openjfx-dev mailing list