RFR: 8234920: Add SpotLight to the selection of 3D light types [v7]

Nir Lisker nlisker at openjdk.java.net
Thu Jan 14 00:34:04 UTC 2021

On Tue, 12 Jan 2021 00:31:54 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> I see you renamed the setPointLight method in the Prism pipelines to setLight and got rid of the separate setSpotLight method. Have you considered whether this will still make sense when adding a DirectionalLight? Maybe leaving the name as setPointLight is best?

Directional light will be simulated as a point light at an infinite distance, making the illumination appear like it's coming from one direction, so I made this renaming deliberately.


PR: https://git.openjdk.java.net/jfx/pull/334

More information about the openjfx-dev mailing list