Integrated: 8165749: java.lang.RuntimeException: dndGesture.dragboard is null in dragDrop
jpereda at openjdk.java.net
Fri Jan 15 09:13:08 UTC 2021
On Wed, 6 Jan 2021 16:20:47 GMT, Jose Pereda <jpereda at openjdk.org> wrote:
> As commented in the JBS issue, there is one single `dndGesture` object in `Scene`, that can be instantiated from three different ways:
> - DropTargetListener, on dragEnter
> - DragGestureListener, on dragGestureRecognized or
> - MouseHandler, processing a right mouse click (these two are mutually exclusive).
> This PR prevents that, for two almost simultaneous drag events (for instance via mouse and touchpad), the `dndGesture` for the last of these events gets initialized again, losing all existing drag info (`dndGesture.dragboard`) that was added to the first one, avoiding the RTE.
> The existing manual test [DndTest](https://github.com/openjdk/jfx/blob/master/tests/manual/dnd/DndTest.java) has been used on MacOS to verify the PR.
This pull request has now been integrated.
Author: Jose Pereda <jpereda at openjdk.org>
Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
8165749: java.lang.RuntimeException: dndGesture.dragboard is null in dragDrop
Reviewed-by: kcr, arapte
More information about the openjfx-dev