RFR: 8234920: Add SpotLight to the selection of 3D light types [v7]

Nir Lisker nlisker at openjdk.java.net
Sat Jan 16 14:41:12 UTC 2021

On Mon, 11 Jan 2021 23:09:19 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>>   Update to the gl pipeline
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGShape3D.java line 125:
>> 123:                     NGPointLight.getDefaultQa(),
>> 124:                     NGPointLight.getDefaultMaxRange(),
>> 125:                     0, 0, 1, 0, 180, 0); // simulating point light);
> Do you think it is worth using defined constants for these?

I had these constants already in `NGPointLight`, but they were accessed in a non-static way so the `setLight` method could be unified for `NGPointLight`s. Since there is no instance of a light in this case (we are artificially making a light), we would need to access them also statically. I made this change, but I'm not sure if it's designed properly.


PR: https://git.openjdk.java.net/jfx/pull/334

More information about the openjfx-dev mailing list