RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS

Johan Vos jvos at openjdk.java.net
Thu Jan 21 13:54:12 UTC 2021

On Thu, 21 Jan 2021 12:47:01 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> By using the anchor location facility of PopupWindows we can avoid miscalculation of the
>> menu's height entirely.
>> This fix also cleans up some documentation issues.
>> This fix introduces tests that check the correct positioning (test_position_)
>> test_position_withCSS reproduces the problem that is fixed with this patch.
>> The other test_position_ cases serve as "proof" that no regressions are introduces.
>> They work before and after the fix is introduced.
> I saw your comment in #381 regarding the removed section of API docs. We can discuss it as part of the review of this PR. I'll take a look and see whether simply removing it is fine or if I can suggest a replacement. It still might need a CSR (I'll let you know), but it would be a simple one to record the doc changes.

This approach looks good to me, and it makes it simpler. 
I agree that some info about the `Side` parameter would be appropriate in the JavaDoc (although it is close to trivial and the source is self-explaining)


PR: https://git.openjdk.java.net/jfx/pull/383

More information about the openjfx-dev mailing list