RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS [v2]
rlichten at openjdk.java.net
Mon Jan 25 11:40:09 UTC 2021
On Fri, 22 Jan 2021 18:54:35 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision:
>> 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS
>> Corrections as per Kevin Rushforth's comments.
>> Also added two more test cases that test right-to-left node orientation.
>> Fixed the implementation and the API documentation.
> modules/javafx.controls/src/main/java/javafx/scene/control/ContextMenu.java line 237:
>> 235: * NodeOrientation.RIGHT_TO_LEFT is set.
>> 236: * Using NodeOrientation.RIGHT_TO_LEFT will also "mirror" the meaning of Side.LEFT and
>> 237: * Side.RIGHT respectively.
> We don't document the effect of node orientation in other controls or in charts, so I wouldn't want to mention it here. Instead you can document the behavior assuming the default effective orientation of `LEFT_TO_RIGHT` (without mentioning it).
> You could make the case that we should document more precisely the effect or NodeOrientation, but that would be a large task, and not something I would want to do for an isolated control in the course of a bug fix (and it would require a CSR).
> The rest of the doc changes look good and don't need a CSR.
Thanks for clarifying. I have adapted the documentation accordingly.
More information about the openjfx-dev