RFR 8207351 jextract should generate properties file containing meta info under META-INF

Henry Jen henry.jen at oracle.com
Wed Jul 18 04:15:46 UTC 2018


I think this is a good start. But I think mix command line arguments into Context is a little messy, jextract.Main is the one parsing the command line options, and I think anything related to command line should stays in there.

Context have the information as result of setup from options by Main, so either we can save required data from Context, or save the command line from Main, but don’t cross the boundary.

The change in collectJarFile, I think those should be in collectJarFile(JarOutputStream, …), not in collectJarFile(Path, …). The previous is public API and used by Runner test, the later is convenient method build on top of that.

Cheers,
Henry



> On Jul 16, 2018, at 9:47 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> Please review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8207351
> 
> Webrev: http://cr.openjdk.java.net/~sundar/8207351/webrev.00/
> 
> Thanks,
> -Sundar



More information about the panama-dev mailing list