[foreign] RFR 8210650: Cursor.isAnonymousStruct is about embedded anon struct/union and not just name being empty
henry.jen at oracle.com
Wed Sep 12 15:57:08 UTC 2018
> On Sep 12, 2018, at 8:53 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> Thanks for your review.
> Updated: http://cr.openjdk.java.net/~sundar/8210650/webrev.01/
> On 12/09/18, 8:39 PM, Henry Jen wrote:
>> Looks good. I would like to see changes in jdk.internal.clang code propagate to the FFI test as well, as the FFI based jdk.internal.clang module should at least offer same capabilities as JNI base.
>>> On Sep 12, 2018, at 6:48 AM, Sundararajan Athijegannathan<sundararajan.athijegannathan at oracle.com> wrote:
>>> Please review.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210650
>>> Webrev: http://cr.openjdk.java.net/~sundar/8210650/webrev.00/
>>> Includes other cleanups regarding equals, toString in Cursor, Type and SourceLocation.
More information about the panama-dev