[foreign] RFR : Fixes to StdLibTest
maurizio.cimadamore at oracle.com
Mon Sep 24 16:59:30 UTC 2018
On 24/09/18 17:43, Sundararajan Athijegannathan wrote:
> Thanks for this patch Jorn!
> I filed a bug to track this:
> PS. I'm testing your patch on Mac.
Works on Linux
> On 24/09/18, 9:28 PM, Jorn Vernee wrote:
>> Please review this patch which does a few fixes to StdLibTest:
>> This patch fixes 3 things:
>> 1.) 'puts' returns a non-negative value on success , but the test
>> was testing > 0. I changed it to >= 0, since the MSVC implementation
>> returns exactly 0.
>> 2.) Switched the test_time test from testing localtime(), which is
>> locale dependent to testing gmtime() which always uses the GMT
>> timezone, since the locale dependency was giving trouble in cygwin .
>> 3.) Also for the test_time test, I changed the way the test
>> parameters are being generated, since it was apparently generating
>> invalid values for windows, so the native function was returning
>> null, and the test was failing.
>> Since I'm not a committer someone else will have to create a commit
>> and push this.
>>  : https://en.cppreference.com/w/c/io/puts
>>  :
More information about the panama-dev