RFR: Only include fpu_control.h on 32-bit x86
mikael.vidstedt at oracle.com
Wed Apr 12 02:44:07 UTC 2017
> On Apr 11, 2017, at 6:18 PM, David Holmes <david.holmes at oracle.com> wrote:
> On 12/04/2017 9:46 AM, Mikael Vidstedt wrote:
>> os_linux_x86_.cpp has some code to set/update/tickle the fpu control word. The code makes use of functions from the fpu_control.h header, but is only used on 32-bit x86. musl doesn’t have the fpu_control.h header file.
> So musl doesn't support 32-bit x86?
I believe there is support in musl for 32-bit x86, and perhaps there is something else we can use to update the fpu control word. For now though, I suggest that we focus on linux/x64. If/when we have everything working on linux/x64 we can go back and add support for other platforms/CPU architectures.
>> This change adds a conditional include guard to only include the fpu_control.h on 32-bit x86 (!AMD64), which matches the guards used in the places further down in the file where the functionality is actually used.
> Using a consistent guard makes a lot of sense.
> I wonder if we even need this FPU control word stuff these days …
More information about the portola-dev