Not sure, but maybe hotspot-dev is the best in this case. <div>Then at least nobody can complain that he didn't knew about the changes later on:)</div><div><span></span><br><div><br>On Tuesday, June 11, 2013, Vladimir Kozlov wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Forgot to include ppc-aix mail alias. Which Hotspot mail alias we will use for reviews?<br>
<br>
Thanks,<br>
Vladimir<br>
<br>
<br>
-------- Original Message --------<br>
Subject: Re: JEP 175 - Review comments<br>
Date: Tue, 11 Jun 2013 09:33:59 -0700<br>
From: Vladimir Kozlov <<a>vladimir.kozlov@oracle.com</a>><br>
To: Lindenmaier, Goetz <<a>goetz.lindenmaier@sap.com</a>><br>
CC: Volker Simonis <<a>volker.simonis@gmail.com</a>>, Â Azeem Jiva <<a>azeem.jiva@oracle.com</a>>, Chris Plummer <<a>chris.plummer@oracle.com</a>><br>
<br>
Here is result of my first attempt to build/test ppc changes together<br>
with our closed sources.<br>
<br>
Small problems:<br>
<br>
src/share/vm/memory/<u></u>allocation.hpp:209: Trailing whitespace<br>
src/share/vm/memory/<u></u>allocation.inline.hpp:121: Trailing whitespace<br>
src/share/vm/opto/escape.cpp:<u></u>2207: Trailing whitespace<br>
src/share/vm/memory/<u></u>allocation.hpp:212: Trailing whitespace<br>
src/share/vm/opto/escape.cpp:<u></u>2214: Trailing whitespace<br>
<br>
Build on MacOS:<br>
<br>
src/share/vm/opto/<u></u>callGenerator.cpp: In member function 'virtual<br>
JVMState* VirtualCallGenerator::<u></u>generate(JVMState*)':<br>
src/share/vm/opto/<u></u>callGenerator.cpp:204: error:<br>
'zero_page_read_protected' is not a member of 'os'<br>
<br>
agent/src/os/bsd/<u></u>MacosxDebuggerLocal.m:54:2: error: #error UNSUPPORTED_ARCH<br>
agent/src/os/bsd/<u></u>MacosxDebuggerLocal.m:167:4: error: #error UNSUPPORTED_ARCH<br>
agent/src/os/bsd/<u></u>MacosxDebuggerLocal.m:591:2: error: #error UNSUPPORTED_ARCH<br>
<br>
<br>
We have several conflict with closed sources builds:<br>
<br>
src/share/vm/utilities/<u></u>elfSymbolTable.cpp: In member function 'bool<br>
ElfSymbolTable::lookup(<u></u>unsigned char*, int*, int*, int*)':<br>
src/share/vm/utilities/<u></u>elfSymbolTable.cpp:97: error: comparison between<br>
signed and unsigned integer expressions<br>
src/share/vm/utilities/<u></u>elfSymbolTable.cpp:124: error: comparison between<br>
signed and unsigned integer expressions<br>
<br>
error: no 'oopDesc** frame::interpreter_frame_<u></u>mirror_addr() const'<br>
member function declared in class 'frame'<br>
<br>
error: no matching function for call to<br>
'SharedRuntime::c_calling_<u></u>convention(BasicType*&, VMRegPair*&, uint&)'<br>
<br>
I think it is due to changes like next:<br>
<br>
-#ifdef PPC<br>
+#ifdef PPC32<br>
  oop* interpreter_frame_mirror_addr(<u></u>) const;<br>
<br>
<br>
Next is easy fix in our closed sources but it requires efforts from our<br>
side:<br>
<br>
src/share/vm/prims/<u></u>methodHandles.cpp: In static member function 'static<br>
void MethodHandles::generate_<u></u>adapters()':<br>
src/share/vm/prims/<u></u>methodHandles.cpp:68: error: 'adapter_code_size'<br>
cannot be used as a function<br>
src/share/vm/prims/<u></u>methodHandles.cpp:70: error: 'adapter_code_size'<br>
cannot be used as a function<br>
<br>
<br>
I would suggest to do such shared changes which affects different builds<br>
later after initial push.<br>
<br>
<br>
Thanks,<br>
Vladimir<br>
<br>
On 6/7/13 3:20 AM, Lindenmaier, Goetz wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Vladimir,<br>
<br>
I updated the repo to jdk8-b92. Â Our nightly tests built and<br>
tested it successfully. Â In case you experience any problems<br>
please tell me the details so I can fix them.<br>
<br>
Best regards,<br>
  Goetz.<br>
<br>
<a href="http://cr.openjdk.java.net/~simonis/ppc-aix-port/index.html" target="_blank">http://cr.openjdk.java.net/~<u></u>simonis/ppc-aix-port/index.<u></u>html</a><br>
<br>
<br>
-----Original Message-----<br>
From: Vladimir Kozlov [mailto:<a>vladimir.kozlov@oracle.com</a>]<br>
Sent: Dienstag, 4. Juni 2013 20:58<br>
To: Simonis, Volker<br>
Cc: Iris Clark; Wintergerst, Michael; Lindenmaier, Goetz; Bernard Traversat; Jeannette Hung; Azeem Jiva; David Therkelsen; Mikael Vidstedt; Neil Richards; Steve Poole; <a>luchsh@cn.ibm.com</a>; Tim Ellison; Alan Bateman<br>
Subject: Re: JEP 175 - Review comments<br>
<br>
Volker,<br>
<br>
Can you or someone update<br>
<a href="http://hg.openjdk.java.net/ppc-aix-port/jdk8/hotspot" target="_blank">http://hg.openjdk.java.net/<u></u>ppc-aix-port/jdk8/hotspot</a> to match latest<br>
sources in <a href="http://hg.openjdk.java.net/jdk8/jdk8/hotspot" target="_blank">http://hg.openjdk.java.net/<u></u>jdk8/jdk8/hotspot</a>?<br>
I just tried to merge them and build Hotspot on x86 without success.<br>
<br>
Thanks,<br>
Vladimir<br>
<br>
On 6/4/13 7:04 AM, Simonis, Volker wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
We intentionally used 'porters-dev' rather than'ppc-aix-port-dev' in the<br>
beginning to address a broader audience for the initial discussions.<br>
<br>
But I'm happy to change that back to 'ppc-aix-port-dev' now.<br>
<br>
Regards,<br>
Volker<br>
<br>
<br>
------------------------------<u></u>------------------------------<u></u>------------<</blockquote></blockquote></blockquote></div></div>