review request for 7008728, update 1: diamond conversion of basic security, permissions, authentication
sean.mullan at oracle.com
Fri Jan 7 08:35:09 PST 2011
It all looks good to me. One minor comment:
: add a space: s/Map<String,Class>/Map<String, Class>
On 1/6/11 7:16 PM, Stuart Marks wrote:
> Hi Sean,
> Here's an updated webrev for 7008728 which we had discussed earlier.
> Basically this webrev includes ONLY changes that use diamond in the initializer
> of a variable or field declaration, where the inferred type of the diamond is
> right there in the declaration. I've removed all the use of diamond from
> assignments, where the declaration (and thus the inferred type) is elsewhere.
> I've also removed the use of diamond from the problematic cases that we noted,
> such as within the ternary (?:) operator and within method arguments.
More information about the security-dev