review request for 7011998: diamond conversion for jgss and pkcs11
weijun.wang at oracle.com
Thu Jan 13 16:50:44 PST 2011
If sunpkcs11.jar includes line number info (which I think yes), then it
needs to be updated. Otherwise, line numbers shown in the exception
stack info will not match the source code.
On 01/14/2011 08:15 AM, Stuart Marks wrote:
> Yes, the byte codes are identical. I compiled with -g:none before and
> after the changes and the classfiles are all identical. (Even though the
> bytecodes are identical, the classfiles would differ because of changed
> line number information, which is disabled with -g:none.)
> So, I assume this means that sunpkcs11.jar doesn't need to be updated,
> and that I can push this changeset without further changes?
> On 1/12/11 7:06 PM, Valerie (Yu-Ching) Peng wrote:
>> The changes look good to me.
>> BTW, I recall seeing in one of your earlier email that the byte code
>> is the
>> same w/ the usage of this diamond operator. Is this so?
>> If not, then we need to update the sunpkcs11.jar also.
>> On 01/12/11 05:30 PM, Stuart Marks wrote:
>>> Hi Valerie,
>>> You're up next for diamond conversion. :-)
>>> These should be pretty straightforward. Almost all changes are variable
>>> initializations. There's one return statement, one use of diamond in a
>>> ternary operator (a ? b : c), and one whitespace fixup.
>>> Webrev is here:
More information about the security-dev