Code review request for 8012637: Adjust CipherInputStream class to work in AEAD/GCM mode

Xuelei Fan xuelei.fan at oracle.com
Thu Jun 13 03:02:26 PDT 2013


Looks fine to me.

A very very minor comment is about the code conversions.  Personally, I
prefer to use braces around all statements (if-else, while, etc). See
also:
http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#15395

-   if (!done) cipher.doFinal();
+   if (!done) {
+       cipher.doFinal();
+   }

Xuelei

On 6/12/2013 6:52 AM, Valerie (Yu-Ching) Peng wrote:
> Xuelei,
> 
> Can you help review this one-line fix?
> 8012637: Adjust CipherInputStream class to work in AEAD/GCM mode
> 
> The webrev is at:
> http://cr.openjdk.java.net/~valeriep/8012637/webrev.00/
> 
> Thanks,
> Valerie



More information about the security-dev mailing list