RFR JDK8007636

Florian Weimer fweimer at redhat.com
Tue Jun 18 04:26:55 PDT 2013


On 06/17/2013 04:29 PM, John Zavgren wrote:
> Greetings:
>
> I'm posting a fix for a memory leak. As you can see, the original code
> deallocated a structure, thereby rendering it's memory invalid, then it
> deallocated the memory that was allocated to one of its data members.
>
> I merely reversed the order of the free() operations.

The change looks okay to me.  However, this addresses not a memory leak, 
but a user-after-free bug.  (It might materialize as a leak if you have 
a malloc implementation that overwrites objects with zeros when they are 
freed, but that seems unlikely.)

-- 
Florian Weimer / Red Hat Product Security Team


More information about the security-dev mailing list