Code review request, 8000456: Add programmatic deadlock detection in SSLEngineDeadlock

Xuelei Fan xuelei.fan at oracle.com
Tue Jun 18 17:36:18 PDT 2013


On 6/19/2013 8:21 AM, Brad Wetmore wrote:
> I enjoy your codereviews because I generally learn about new libraries.  :)
> 
> On 6/18/2013 2:47 AM, Xuelei Fan wrote:
>> Hi,
>>
>> Please review this test update:
>>
>> http://cr.openjdk.java.net/~xuelei/8000456/webrev.00/
>>
>> The test case SSLEngineDeadlock.java is used to detect the deadlock in
>> SSLEngine.  However, the result depends on time out.  It is hard to tell
>> whether the timeout is caused by deadlock or heavy loaded systems.
> 
> Do you want to call:
> 
>     getThreadInfo(long id, int maxDepth)
> 
> instead?  That way you can output the deadlocked location which will
> help debugging in case this ever shows up again.
> 
Good suggestion. I will update to use:
    getThreadInfo(long id, Integer.MAX_VALUE)

Thanks,
Xuelei



More information about the security-dev mailing list