Code review request: 8017453: ReplayCache tests fail on multiple platforms (was Re: Please be prepared for possible test failures (was Fwd: [JBS] (JDK-8001326) Improve Kerberos replay caching))

Weijun Wang weijun.wang at oracle.com
Sun Jun 23 21:41:03 PDT 2013


I would stick to SunOS since that's how the JGSS native provider detects
the OS. Maybe do a detailed check later.

On 6/24/13 12:36 PM, Xuelei Fan wrote:
> On 6/24/2013 12:29 PM, Weijun Wang wrote:
>> Oh, actually it should be SunOS.
>>
> Really? Then I would suggest you also check "Solaris".
> 
> http://www.javaneverdie.com/java/java-os-name-property-values/
> 
> Xuelei
> 
>> On 6/24/13 11:28 AM, Xuelei Fan wrote:
>>> On 6/24/2013 11:04 AM, Weijun Wang wrote:
>>>> Oh, no
>>>>
>>>>    if (!os.startsWith("Solaris") && !os.startsWith("Linux")) {
>>>>
>>> Good.
>>>
>>> Xuelei
>>>
>>>> --Max
>>>>
>>>> On 6/24/13 11:01 AM, Weijun Wang wrote:
>>>>> How about
>>>>>
>>>>>                if (!os.startsWith("Solaris") || !os.startsWith("Linux")) {
>>>>>                    mode = -1;
>>>>>                }
>>>>>
>>>>> Thanks
>>>>> Max
>>>>>
>>>>>
>>>>> On 6/24/13 10:35 AM, Xuelei Fan wrote:
>>>>>> On 6/24/2013 10:01 AM, Weijun Wang wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 6/24/13 9:49 AM, Xuelei Fan wrote:
>>>>>>>> ReplayCacheTestProc.java
>>>>>>>> ========================
>>>>>>>> 75       String os = System.getProperty("os.name", "???");
>>>>>>>>
>>>>>>>> What happens if "os" is "???"?
>>>>>>>
>>>>>>> Then it's neither Windows nor Mac OS X. :)
>>>>>>>
>>>>>> The code means except Windows and Mac OS X, all other platform supports
>>>>>> native mode, even the OS name is unknown.
>>>>>>
>>>>>>> I gave a default value so that the result will not be null. Although the
>>>>>>> system property "os.name" should always have a value, it makes me
>>>>>>> comfort not thinking of possible NPE.
>>>>>>>
>>>>>> ;-) I guess you may also worry that if the OS does not support native
>>>>>> mode other than Windows and Mac OS X, the test will fail again.
>>>>>>
>>>>>> As you are here already, I would suggest to make more improvement. When
>>>>>> the OS is unknown, java mode should be used .
>>>>>>
>>>>>> Xuelei
>>>>>>
>>>>>>> Thanks
>>>>>>> Max
>>>>>>>
>>>>>>>>
>>>>>>>> Xuelei
>>>>>>>>
>>>>>>>> On 6/24/2013 12:36 AM, Wang Weijun wrote:
>>>>>>>>> Send again. And BTW, JPRT runs fine.
>>>>>>>>>
>>>>>>>>> ÔÚ Jun 23, 2013£¬6:29 PM£¬Weijun Wang <weijun.wang at oracle.com> дµÀ£º
>>>>>>>>>
>>>>>>>>>> The macosx problem found, the machine's native GSS does not support shared replaycache.
>>>>>>>>>>
>>>>>>>>>> *Valerie* and/or *Xuelei*, can you please review the fix?
>>>>>>>>>>
>>>>>>>>>>        http://cr.openjdk.java.net/~weijun/8017453/webrev.00/
>>>>>>>>>>
>>>>>>>>>>
>>>
> 


More information about the security-dev mailing list