Code review request: 8016051: Possible ClassCastException in KdcComm

Artem Smotrakov artem.smotrakov at oracle.com
Tue Jun 25 05:33:16 PDT 2013


Hi Max

I updated the webrev:

http://1.smotrakov.z8.ru/8016051/webrev.01/src/share/classes/sun/security/krb5/KdcComm.java.udiff.html

I built OpenJDK on Linux x64 according to 
http://hg.openjdk.java.net/jdk8/build/raw-file/tip/README-builds.html, 
and ran JCK, SQE (related to Kerberos), jdk_security tests (listed in 
http://hg.openjdk.java.net/jdk8/build/raw-file/tip/README-builds.html)

Artem

On 25.06.2013 16:04, Weijun Wang wrote:
> Hi Artem
>
> Line 221 is a little too long, you may want to break it. Otherwise, fine.
>
> Have you tried running JPRT with at least the jdk_security test?
>
> Thanks
> Max
>
>
> On 6/25/2013 1:35 PM, Artem Smotrakov wrote:
>> Hi,
>>
>> please review this fix for 8:
>>
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016051
>> http://1.smotrakov.z8.ru/8016051/webrev.00/
>>
>> It fixes a possible ClassCastException if an exception thrown from
>> send() method is not IOException or KrbException. The first exception is
>> thrown if all connections to KDC fail. See also:
>>
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017714.html 
>>
>>
>> Artem

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130625/6e95f17b/attachment.html 


More information about the security-dev mailing list