[8] Review Request: 8019360: Cleanup of the javadoc <code> tag in java.security.*

Jason Uh jason.uh at oracle.com
Fri Jun 28 10:46:31 PDT 2013


Thanks, Joe. I've updated my changes with all the things you pointed 
out. The new webrev:
http://cr.openjdk.java.net/~juh/8019360/webrev.01/

I'll push this now.

Thanks,
Jason

On 6/27/13 11:36 PM, Joe Darcy wrote:
> Hi Jason,
>
> On 06/27/2013 11:11 PM, Jason Uh wrote:
>> Joe,
>>
>> Could I please get a review of this changeset?
>>
>> These changes convert the remaining <code>...</code> and <tt>...</tt>
>> tags to {@code ...} in java.security and its subpackages.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~juh/8019360/webrev.00/
>
> The {@code} related changes look fine to go back as-as.
>
>>
>> I've also changed each package's package.html file to
>> package-info.java. If you object to the inclusion of those changes in
>> this changeset, I could do that under a separate bug.
>
> The package-related changes need a few small edits. In
>
>      src/share/classes/java/security/acl/package-info.java
>
> These lines should be deleted:
>
>    31  * <!--
>    32  * <h2>Package Specification</h2>
>    33  *
>    34  * ##### FILL IN ANY SPECS NEEDED BY JAVA COMPATIBILITY KIT #####
>    35  * <ul>
>    36  *   <li><a href="">##### REFER TO ANY FRAMEMAKER SPECIFICATION
> HERE #####</a>
>    37  * </ul>
>    38  *
>    39  * <h2>Related Documentation</h2>
>    40  *
>    41  * For overviews, tutorials, examples, guides, and tool
> documentation, please see:
>    42  * <ul>
>    43  *   <li><a href="">##### REFER TO NON-SPEC DOCUMENTATION HERE
> #####</a>
>    44  * </ul>
>    45  * -->
>
> Also in the package files, please replace
>
>      <SUP>TM</SUP>
>
> with
>
>      &trade;
>
>
> With those changes, I approve the package changes going back,
>
>>
>> No undesirable changes were detected by specdiff.
>>
>>
>
> Good to know :-)
>
> Thanks,
>
> -Joe
>



More information about the security-dev mailing list