[JDK 9] RFR: 8041781: Need new regression tests for PBE keys

Xuelei Fan Xuelei.Fan at Oracle.COM
Fri Jun 27 05:19:36 UTC 2014


Looks fine to me.

Would you like also add tests for PBEMAC, e.g., PBEWithHmacSHA1?

Thanks,
Xuelei

On 6/27/2014 5:02 AM, Rajan Halade wrote:
> Ping...can someone help review this please.
>
> Thanks,
> Rajan
> On 6/18/14, 3:36 PM, Rajan Halade wrote:
>> May I request you to review these 3 new tests to be added for PBE
>> keys. New tests are added to address following:
>>
>> - seal/unseal works correctly with PBE algorithms
>> - key wrapper works correctly with PBEKey
>> - SecretKeyFactory.translateKey() method works
>>
>> JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8041781
>> Webrev: http://cr.openjdk.java.net/~rhalade/8041781/webrev.00/
>>
>> Thanks,
>> Rajan
>



More information about the security-dev mailing list