[9] RFR: 8076486: javax/security/auth/Subject/doAs/NestedActions.java fails if extra VM options are given

Weijun Wang weijun.wang at oracle.com
Mon May 4 08:49:47 UTC 2015


Artem

If a string starts with whitespace(s), the first element of 
split("\\s+") will be an empty string. If you can be sure JAVA_OPTS does 
not have them, your code change is fine.

Thanks
Max

On 4/29/2015 11:44 PM, Artem Smotrakov wrote:
> Hi Max,
>
> These fancy things sometimes make me forget about simpler ways :-)
>
> Please take a look
>
> http://cr.openjdk.java.net/~asmotrak/8076486/webrev.01/
>
> Thanks!
>
> Artem
>
> On 04/29/2015 05:04 PM, Weijun Wang wrote:
>> Maybe you can call JAVA_OPTS.trim().split("\\s+") to avoid the filtering.
>>
>> And it seems Collections.addAll() can add an array to a list.
>>
>> Of course, you are free to exercise any fancy jdk8 features. :-)
>>
>> Thanks
>> Max
>>
>> On 4/29/2015 3:23 PM, Artem Smotrakov wrote:
>>> Hello,
>>>
>>> Please review this fix for
>>> javax/security/auth/Subject/doAs/NestedActions.java test.
>>>
>>> The test runs java in a separate process. It fails if multiple java
>>> options are passed because ProcessBuilder expects each parameter to be
>>> put in to a separate array element, but the test didn't do that. I
>>> updated the test to split java option string, and put each option in a
>>> separate array element.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076486
>>> Webrev: http://cr.openjdk.java.net/~asmotrak/8076486/webrev.00/
>>>
>>> Artem
>


More information about the security-dev mailing list