[JEP-219/JDK-8043758] Code Review Request: Datagram Transport Layer Security (DTLS)

Weijun Wang weijun.wang at oracle.com
Thu May 21 10:07:48 UTC 2015


NEED_UNWRAP_AGAIN:

So you are asking the user to call unwrap() on nothing? Or no matter 
what the argument is you just don't touch it? I'd rather see a new 
status NEED_PROCEED and a new method proceed() that has no argument at all.

Tests:

I see you send/receive data with DatagramSocket. Not sure how UDP on 
localhost is more reliable than on a network, but is it possible to just 
pass the byte arrays between client and server? It's also easier to 
simulate packet loss and wrong order this way.

--Max

On 5/21/2015 9:25 AM, Xuelei Fan wrote:
> Hi,
>
> Please review DTLS implementation [JEP-219/JDK-8043758]:
>
> webrev: http://cr.openjdk.java.net/~xuelei/8043758/webrev.latest/
> JBS: https://bugs.openjdk.java.net/browse/JDK-8043758
>
> I would greatly appreciate it if you could send me feedback on or before
> May 28, 2015.
>
> Thanks & Regards,
> Xuelei Fan
>


More information about the security-dev mailing list