[JEP-219/JDK-8043758] Code Review Request: Datagram Transport Layer Security (DTLS)

Xuelei Fan xuelei.fan at oracle.com
Thu May 21 11:19:46 UTC 2015


On 5/21/2015 6:07 PM, Weijun Wang wrote:
> NEED_UNWRAP_AGAIN:
> 
> So you are asking the user to call unwrap() on nothing? Or no matter
> what the argument is you just don't touch it?
As previous behaviors, the argument may be not touched.  For this case,
the input would not be touched.

> I'd rather see a new
> status NEED_PROCEED and a new method proceed() that has no argument at all.
> 
Add a new method would make the application code more complicated.  At
present, applications only need to call wrap() and unwrap(), and need
not to concern about whether the method would produce bytes or not.  I
want to keep it simple as before.

> Tests:
> 
> I see you send/receive data with DatagramSocket. Not sure how UDP on
> localhost is more reliable than on a network, but is it possible to just
> pass the byte arrays between client and server? It's also easier to
> simulate packet loss and wrong order this way.
> 
Yes, it is easier.  However, some of the tests are also used to
illustrate how to do DTLS programming.  I may use client and server byte
exchange directly later, if more tests are required.

Thanks,
Xuelei

> --Max
> 
> On 5/21/2015 9:25 AM, Xuelei Fan wrote:
>> Hi,
>>
>> Please review DTLS implementation [JEP-219/JDK-8043758]:
>>
>> webrev: http://cr.openjdk.java.net/~xuelei/8043758/webrev.latest/
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8043758
>>
>> I would greatly appreciate it if you could send me feedback on or before
>> May 28, 2015.
>>
>> Thanks & Regards,
>> Xuelei Fan
>>



More information about the security-dev mailing list