[JEP-219/JDK-8043758] Code Review Request: Datagram Transport Layer Security (DTLS)

Konstantin Shefov konstantin.shefov at oracle.com
Thu May 21 11:31:11 UTC 2015


Hi Xuelei,

You have the following tests: "DTLSOverDatagram.java", "Reordered.java", 
"Retransmission.java". Their code is pretty much the same despite some 
differences.
I think it would be better to create a base test class with all common 
code and then inherit tests from that class to avoid code duplication.

-Konstantin

On 21.05.2015 14:19, Xuelei Fan wrote:
> Hi,
> >>
> >>Please review DTLS implementation [JEP-219/JDK-8043758]:
> >>
> >>webrev:http://cr.openjdk.java.net/~xuelei/8043758/webrev.latest/
> >>JBS:https://bugs.openjdk.java.net/browse/JDK-8043758
> >>
> >>I would greatly appreciate it if you could send me feedback on or before
> >>May 28, 2015.
> >>
> >>Thanks & Regards,
> >>Xuelei Fan



More information about the security-dev mailing list