RFR 8048357: PKCS basic tests

Amanda Jiang amanda.jiang at oracle.com
Fri Nov 13 08:57:28 UTC 2015


Hi Max,

Please check the updated webrev which address your comments, please let 
me know if you have any other suggestions.
http://cr.openjdk.java.net/~amjiang/8048357/webrev.02/

Thanks,
Amanda

On 15/8/21 上午12:13, Weijun Wang wrote:
> PKCS10AttrOrder.java:
>
> - Why not inline revAttributes(), prov() and constructMap()? They are 
> only used once. Putting the content into the main method is more clear.
>
> - You can create separate method for the while look checks. The 2 look 
> identical.
>
> PKCS10AttributeReader.java:
>
> - Is it OK to indent the data in the comment to multiple levels?
>
> - Again, initMap() not necessary.
>
> PKCS7VerifyTest.java:
>
> - Not sure what this is for. The 1st and 2nd argument of the @run line 
> are the same?
those 3 arguments are actually for two different test cases, I use two 
@run tags in updated webrev and add some comments in test to make it clear.
>
> SignerOrder.java:
>
> - Comment on what derString1 and derString1 are.
>
> - What do you expect verifs1.length and verifs2.length to be? Will you 
> also check it?
Yes I do check verifs1.length and verifs2.length should be same.

  121         if (verifs1.length != verifs2.length) {
  122             throw new RuntimeException("Length or Original vs read-in "
  123                     + "should be same");
  124         }



>
> PKCS8Test.java:
>
> - Typo: s/recieved/received/g
>
> Thanks
> Max
>
> On 08/21/2015 07:11 AM, Amanda Jiang wrote:
>> Hi All,
>>
>> Please be free to review new tests for conformance testing of PKCS.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8048357
>> webrev: http://cr.openjdk.java.net/~amjiang/8048357/webrev.01/
>>
>> Thanks,
>> Amanda
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20151113/fb60233c/attachment.html>


More information about the security-dev mailing list