[8u-dev] Request for Review + Request for Approval for Backport : 8048147: Privilege tests with JAAS Subject.doAs + 8076486 (test's fix)

Svetlana Nikandrova svetlana.nikandrova at oracle.com
Tue Apr 5 13:58:53 UTC 2016


Hello,

please review and approve the backport of tests enhancement:
Original test from
https://bugs.openjdk.java.net/browse/JDK-8048147
jdk 9 review: 
http://mail.openjdk.java.net/pipermail/security-dev/2015-March/011902.html
jdk 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7969f7b6465e

was combined with it's fix:
https://bugs.openjdk.java.net/browse/JDK-8076486
jdk 9 review: 
http://mail.openjdk.java.net/pipermail/security-dev/2015-May/012111.html
jdk 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/fff8ab918557

Webrev:
http://cr.openjdk.java.net/~snikandrova/8048147/webrev.00/ 
<http://cr.openjdk.java.net/%7Esnikandrova/8048147/webrev.00/>

The test's code differs from jdk9 as InputStream's transferTo method was 
introduced in jdk 9. I rewrite that part as:

+                try (FileInputStream fis = new FileInputStream(
+                        TEST_CLASSES + FS + file)) {
+                    byte[] buffer = new byte[1024];
+                    int read;
+                    while ((read = fis.read(buffer, 0, buffer.length)) > 0) {
+                        jos.write(buffer, 0, read);
+                    }
+                }


All the other code is identical. Tested with JPRT.

Thank you,
Svetlana


More information about the security-dev mailing list