RFR : 8153531: Improve exception messaging for RSAClientKeyExchange

Seán Coffey sean.coffey at oracle.com
Thu Apr 7 09:12:44 UTC 2016


Thanks. Line width adjustments made and changes pushed :

http://hg.openjdk.java.net/jdk9/dev/jdk/rev/0b18ad7184bc

Regards,
Sean.

On 06/04/2016 00:21, Xuelei Fan wrote:
> Looks fine to me.   Please keep each line bellow 80 characters.
>
> Thanks,
> Xuelei
>
>
> On 4/6/2016 2:23 AM, Seán Coffey wrote:
>> Some trivial updates to exception messages that should ease debugging
>> for future issues:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8153531
>> webrev : http://cr.openjdk.java.net/~coffeys/webrev.8153531/webrev/
>>   
>> one edit I thought I'd highlight:
>>
>> I've converted this exception into an SSLException to make use of the 2
>> arg constructor :
>>
>>> ! throw new SSLProtocolException(
>>> ! "Unable to process PreMasterSecret, may be too big");
>> I could use the initCause approach if necessary but figured that it
>> didn't matter.
>>
>> -- 
>> Regards,
>> Sean.
>>



More information about the security-dev mailing list