RFR 8153545: sun/security/pkcs11/Provider/Login.sh fails on Linux

Wang Weijun weijun.wang at oracle.com
Sat Apr 9 08:46:33 UTC 2016


Hi Amanda,

This is better.

On the other hand, I read the bug report and am not sure if this is the correct way to fix it. Maybe the ("java.security.SecurityPermission" "putProviderProperty.SunDeploy-MozillaJSS") permission should be granted? Or maybe this is a source bug? Artem reported that the problem is only on linux-x86. It's better we get a consistent behavior across platforms.

Thanks,
Max

> On Apr 9, 2016, at 8:20 AM, Amanda Jiang <amanda.jiang at oracle.com> wrote:
> 
> Hi Max,
> 
> Thanks for reviewing, you are right, "sm" should be the correct argument.
> I updated the test argument and PKCS11Test, please check the new webrev:
> http://cr.openjdk.java.net/~amjiang/8153545/webrev.02/
> 
> Thanks,
> Amanda
> 
> On 16/4/8 上午12:28, Wang Weijun wrote:
>> Hi Amanda
>> 
>> I am not familiar with the tests, but it looks like the 1st args argument should be "sm" [1] to enable the security manager, not "true".
>> 
>> If PKCS11Test always uses args as command and optional argument(s), maybe you should throw an exception if the command is unknown.
>> 
>> Thanks
>> Max
>> 
>> [1] http://hg.openjdk.java.net/jdk9/dev/jdk/file/cac52c9da800/test/sun/security/pkcs11/PKCS11Test.java#l184
>> 
>> 
>>> On Apr 8, 2016, at 1:09 PM, Amanda Jiang <amanda.jiang at oracle.com> wrote:
>>> 
>>> Hi All,
>>> 
>>> Please help to review following changeset which fixes test bug for sun/security/pkcs11/Provider/Login.sh and another similar failed test.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8153545
>>> Changest: http://cr.openjdk.java.net/~amjiang/8153545/webrev.01/
>>> 
>>> Thanks,
>>> Amanda
> 



More information about the security-dev mailing list