RFR: 8154231: Simplify access to System properties from JDK code

Claes Redestad claes.redestad at oracle.com
Wed Apr 20 15:17:56 UTC 2016


On 2016-04-20 16:58, Wang Weijun wrote:
> This is quite convenient.

Glad you like it!

> We not cover the other modules?
>
>      exports sun.security.action to
>          java.desktop,
>          java.security.jgss,
>          jdk.crypto.pkcs11;

I was worried I included too many changes in this patch as it is. :-)

If this patch is accepted my intention is to file follow-up RFEs for the 
other modules.

/Claes

>
> Thanks
> Max
>
>> On Apr 20, 2016, at 10:44 PM, Claes Redestad <claes.redestad at oracle.com> wrote:
>>
>> Hello,
>>
>> now that the sun.security.action package is encapsulated we can simplify internal code to get System properties.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154231
>> Webrev: http://cr.openjdk.java.net/~redestad/8154231/webrev.01/
>>
>> This adds a few convenience methods to GetPropertyAction[1] and GetIntegerAction[2]. Since the code calling into this can be streamlined, this leads to a net static footprint reduction of the java.base module and a tiny startup improvement.
>>
>> Thanks!
>>
>> /Claes
>>
>> [1] http://cr.openjdk.java.net/~redestad/8154231/webrev.01/src/java.base/share/classes/sun/security/action/GetPropertyAction.java.udiff.html
>> [2] http://cr.openjdk.java.net/~redestad/8154231/webrev.01/src/java.base/share/classes/sun/security/action/GetIntegerAction.java.udiff.html



More information about the security-dev mailing list