RFR: 8154231: Simplify access to System properties from JDK code

Chris Hegarty chris.hegarty at oracle.com
Wed Apr 20 18:51:54 UTC 2016


On 20 Apr 2016, at 15:44, Claes Redestad <claes.redestad at oracle.com> wrote:

> Hello,
> 
> now that the sun.security.action package is encapsulated we can simplify internal code to get System properties.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8154231
> Webrev: http://cr.openjdk.java.net/~redestad/8154231/webrev.01/

This looks very nice.

Did you accidentally remove supportsTransparentAuth in the unix version 
of NTLMAuthentication.java ? It is used reflectively by 
sun.net.www.protocol.http.NTLMAuthenticationProxy. Otherwise, this looks
fine to me.

-Chris.

Note to self; I need to revisit the sun.reflect properties.



> This adds a few convenience methods to GetPropertyAction[1] and GetIntegerAction[2]. Since the code calling into this can be streamlined, this leads to a net static footprint reduction of the java.base module and a tiny startup improvement.
> 
> Thanks!
> 
> /Claes
> 
> [1] http://cr.openjdk.java.net/~redestad/8154231/webrev.01/src/java.base/share/classes/sun/security/action/GetPropertyAction.java.udiff.html
> [2] http://cr.openjdk.java.net/~redestad/8154231/webrev.01/src/java.base/share/classes/sun/security/action/GetIntegerAction.java.udiff.html



More information about the security-dev mailing list