RFR: 8154231: Simplify access to System properties from JDK code

Chris Hegarty chris.hegarty at oracle.com
Thu Apr 21 09:57:54 UTC 2016


On 20 Apr 2016, at 20:34, Claes Redestad <claes.redestad at oracle.com> wrote:

> 
> 
> On 2016-04-20 20:51, Chris Hegarty wrote:
>> On 20 Apr 2016, at 15:44, Claes Redestad <claes.redestad at oracle.com> wrote:
>> 
>>> Hello,
>>> 
>>> now that the sun.security.action package is encapsulated we can simplify internal code to get System properties.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154231
>>> Webrev: http://cr.openjdk.java.net/~redestad/8154231/webrev.01/
>> This looks very nice.
> 
> Thanks!
> 
>> 
>> Did you accidentally remove supportsTransparentAuth in the unix version
>> of NTLMAuthentication.java ? It is used reflectively by
>> sun.net.www.protocol.http.NTLMAuthenticationProxy. Otherwise, this looks
>> fine to me.
> 
> Oops, nice catch. Updated.

I’m happy with this version. Thanks.

-Chris.



More information about the security-dev mailing list