RFR 8180570: Refactor sun/security/mscapi shell tests to plain java tests

Weijun Wang weijun.wang at oracle.com
Tue Mar 27 08:09:49 UTC 2018


Hi Artem

Long time no see. I checked and you're still a reviewer. Great.

Thanks for the good suggestions.

On the other hand, MSCAPI keystore is a little strange in alias names, could be duplicated, could have key with a cert. I'll try out on a real machine.

--Max

> On Mar 27, 2018, at 4:03 PM, Artem Smotrakov <artem.smotrakov at gmail.com> wrote:
> 
> Hi Max,
> 
> KeytoolChangeAlias.java:
> - maybe better to run ks.deleteEntry("13579") in a finally block
> - should it delete "246810" as well?
> 
> Otherwise looks good to me :)
> 
> Artem
> 
> 
> 
> 2018-03-27 9:51 GMT+02:00 Weijun Wang <weijun.wang at oracle.com>:
> Ping again.
> 
> > On Mar 8, 2018, at 8:37 PM, Weijun Wang <weijun.wang at oracle.com> wrote:
> >
> >
> >
> >> On Mar 8, 2018, at 6:13 PM, Weijun Wang <weijun.wang at oracle.com> wrote:
> >>
> >> Please take a review at
> >>
> >>  http://cr.openjdk.java.net/~weijun/8180570/webrev.00
> >
> > Updated in place.
> >
> >>
> >> Several notes:
> >>
> >> 1. The original KeyStoreCompatibilityMode.sh does not check the exit value of each command. I assume it should.
> >>
> >> 2. I don't really understand what SystemDrive is for in RSAEncryptDecrypt.sh. Maybe about running the test from \\remote\share? I also cannot find JDK-6449799.
> >>
> >> 3. SecurityTools::getProcessBuilder is modified a little. On my Windows machine without cygwin (major reason why I want to work on this RFE), setting -Djava.security.egd=file:/dev/./urandom causes an error.
> >>
> >> 4. nonUniqueAliases/NonUniqueAliases.sh is not touched. It has an @ignore.
> >
> > This one is also updated. I tried it on a Windows Server 2016 with certutil.exe and it succeeds.
> >
> > --Max
> >
> >>
> >> Thanks
> >> Max
> >>
> >
> 
> 



More information about the security-dev mailing list