Need reviewer - warnings in serviceability code
Kelly.Ohair at Sun.COM
Mon Jul 21 11:05:57 PDT 2008
Just some fixes to remove compiler warnings:
6725543: Compiler warnings in serviceability native code
or see attached patch file, changes are relatively localized, easy to understand.
Wish I had a way of posting a webrev :^(
Changes include removing some unused vars, adding some casts (mostly on
on strlen()), and renaming INT32 and UINT32 typedefs to avoid conflicts
on windows, which also defines these typedefs.
Changed use of INT32 and UINT32 in transport/socket code to NETLONG and NETULONG
since these are really "network longs" as far as I can tell.
Just using INT32 and UINT32 on Windows may make the most sense, but these files are
in the 'share' section and should be platform independent.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the serviceability-dev