Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors
Andrew John Hughes
gnu_andrew at member.fsf.org
Thu Aug 20 16:26:21 PDT 2009
2009/8/21 Kelly O'Hair <Kelly.Ohair at sun.com>:
> Still need reviewer ...
> 6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project
> Pretty harmless code cleanup on the tool used to generate
> some of the JDWP code for the debugger.
The Java part looks pretty sane to me:
* I think the change to ConstantSetNode is particularly important,
as it's eliminating a race condition (another class could initialise
the variable after the null check but before the new). To keep the
same lazy initialisation semantics as before, you could use the
on-demand holder idiom
but I doubt a single map is going to be too much overhead to
* The change to Parse.java means exceptions will now be thrown that
were being caught before. I can't see this being a major issue as
part of a tool, it's more of a problem in changing the semantics of
API methods but something to be aware of nonetheless. I much prefer
the new version; swallowing exceptions on mass is very bad practice.
Sorry I can't really comment on the NetBeans changes, but it appears
to be a set of new files rather than changes; is this correct?
Hope that helps,
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the serviceability-dev