Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors
Andrew John Hughes
gnu_andrew at member.fsf.org
Fri Aug 21 09:32:58 PDT 2009
2009/8/21 Kelly O'Hair <Kelly.Ohair at sun.com>:
> Kelly O'Hair wrote:
>> Still need reviewer ...
>> 6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project
>> Pretty harmless code cleanup on the tool used to generate
>> some of the JDWP code for the debugger.
> The webrev has been updated.
> The field constantMap is now final.
> The throw in Main.java usage() is gone and use of usage() is now followed by
> a simple return from main().
> Thanks for the reviews from Andrew, Alan, and Tim.
> Let me know if this looks ok now.
Looks ok to me.
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the serviceability-dev