Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException
Alan.Bateman at Sun.COM
Thu Aug 27 21:50:33 PDT 2009
Kelly O'Hair wrote:
> expected = strlen(hello);
> Should probably be:
> expected = (int)strlen(hello);
Yes, it should.
> And I would almost think that this:
> char msg;
> should be:
> char msg[80+expected*2];
> and snprintf() used rather than sprintf? But not a big deal.
Make sense, and using snprintf would avoid the a similar issue in the
future, if the message was changed to be much longer.
> Looks good otherwise.
Thanks Kelly, Tim, - I'll sort this out Monday (I'm not around Friday).
More information about the serviceability-dev