Review Request for 6876135: Add PlatformLoggingMXBean to eliminate the dependency on JMX from logging
Mandy.Chung at Sun.COM
Thu Oct 22 12:41:43 PDT 2009
Alan Bateman wrote:
> This looks good to me. A couple of comments:
Thanks for the review.
> - I notice in ManagementFactoryHelper that you are using
> ObjectName.valueOf. I assume this will need to change due to the
> back-port of JSR 255.
I have sync'ed with the latest TL changesets.
> - In j.u.logging.Loggging I wonder if some imports can be removed.
> - Copyright date range in PlatformLoggingMXBean should be 2009.
> - The re-work of the logging proxy looks good and eliminates the use
> of the reflection. It might be useful to move LoggingProxyImpl isn't
> isn't own package - that would make it easier to assign to the
> "logging" module without needing to list the class explicitly.
I moved it to java.util.logging and added a static field to be accessed
More information about the serviceability-dev